envoyproxy/envoy

API request: xds async NACK

Open

#9,447 opened on 2019年12月21日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdsenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

When envoy receives a listener from management server it has 3 choices

  1. accept listener and put it in ready state
  2. Reject listener with a NACK
  3. Accept config and put listener in a warming state awaiting an async operation.

If the async operation fails for any reason and it was performed against separate management server, the original management server has no way to know what happened.

There should be a way to indicate a NACK after async operations complete.

This happens with SDS, Wasm code fetch via url or fcds.

Related issues: https://github.com/envoyproxy/envoy/issues/5739 https://github.com/envoyproxy/envoy/issues/7867

コントリビューターガイド