Signal test failed caused by using signal-unsafe function
#8,193 opened on 2019年9月10日
Repository metrics
- Stars
- (27,997 stars)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
Title: Signal test failed caused by using signal-unsafe function
Description:
On arm64 platform, SignalsDeathTest.InvalidAddressDeathTest test case failed since the logger class use the signal-unsafe function when processing SIGSEGV signal.
When SIGSEGV signal was sent to envoy from OS, it will invoke the sighandler function for print log information. From the following diagram, we could see, eventually, the os/glibc function locatime_r was invoked. But, as we known, the localtime_r function is not suitable for using in signal processing handler. It mainly because that the localtime_r function was implemented by __tz_convert function that will try to get the tzset_lock which used for reading & setting time zone. But the signal handler should not try to get the lock.
Finally, could we implement another safe log system which only used for signal processing ?
Logs: SignalFailed.txt