envoyproxy/envoy

Avoid using HeaderMapImpl for gRPC metadata

オープン

#7,921 opened on 2019/08/14

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)C++ (5,373 件のフォーク)batch import
area/securitybughelp wanted

Repository metrics

Stars
 (27,997 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Today, we use HeaderMapImpl for gRPC metadata, e.g. https://github.com/envoyproxy/envoy/blob/3dd84d3b41b6be378ccb71e81c0063a84bb956e3/include/envoy/grpc/async_client.h#L70. This is not safe, since in general, this metadata may contain binary and HeaderMapImpl can't contain NUL.

We should switch to using a simple map or the like to model these values, treating them as metadata rather than headers.

コントリビューターガイド