envoyproxy/envoy

XRayConfig_SegmentFields can't be configured correctly from an xDS control plane

Open

#31,142 opened on 2023年12月1日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/awsarea/tracingenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

Title: XRayConfig_SegmentFields can't be configured correctly from an xDS control plane

Description:

Currently the XRayConfig_SegmentFields.Origin and XRayConfig_SegmentFields.Aws fields will allow configuring that the trace segment comes from the correct origin as per the Optional Segment Fields in the AWS Segment fields documentation.

The aws object that needs to be sent to make this origin be considered valid requires the following data:

ecs – Information about an Amazon ECS container.
- container – The hostname of your container.
- container_id – The full container ID of your container.
- container_arn – The ARN of your container instance.

This is possible to do using sed and yaml on statically configured envoy hosts.

However, an xDS server cannot populate this with meaningful data and it should be handled internally by envoy's XRay tracing features. I believe that detecting the correct data should be up to each individual envoy proxy at runtime, and should not be configurable here either in the yaml or in the xDS gRPC structs.

Relevant Links:

コントリビューターガイド