Allow historically "core" clusters to use custom cluster configuration
#28,752 opened on 2023年8月1日
Repository metrics
- Stars
- (27,997 stars)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
Title: Allow historically "core" clusters to use custom cluster configuration
Description: Custom clusters as an extension point were added in https://github.com/envoyproxy/envoy/issues/5780. As part of slimming down the binary for EM, we moved "traditional" clusters to extensions e.g. in https://github.com/envoyproxy/envoy/pull/23920, https://github.com/envoyproxy/envoy/pull/23890, etc.
While some of the historically core clusters can be configured via custom cluster type in
It works for static clusters, but it doesn't work for eds clusters -- instead EDS clusters rely on using the traditional configuration when it was part of "core". We'd expect CustomClusterType configuring an EDS cluster to "just work" with EDS clusters by having the config packed into the CustomClusterType typed_config but it gets rejected during validation.
This may apply to other "historical" core cluster types as well.