envoyproxy/envoy

`schema_validator_tool` should not be `testonly`

Open

#26,390 opened on 2023年3月28日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/releasearea/schema_validatorbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

Currently the schema_validator_tool is built using envoy_cc_test which marks it testonly and it in turn depends on a bunch of test libs that are likewise testonly

this should not be the case given that this tool is published, and means that it cannot be depended upon as a build target by other non-test build targets

i made an inexpert attempt at doing this, but found myself copying out increasingly large chunks of the test framework. I gave up when i needed to start copying out the test thread code

コントリビューターガイド