envoyproxy/envoy
stats: retain Scopes for some amount of time after the last reference to them is dropped, to avoid leaking data when xds removes a scope
オープン
#23,619 opened on 2022/10/21
area/statsenhancementhelp wantedno stalebot
Repository metrics
- Stars
- (27,997 個のスター)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
Title: When an xDS update removes a cluster, any stats that get updated after the most recent sink or scrape will get dropped when the ScopeSharedPtr held in the cluster gets dropped.
Description:
To avoid this we should delay the destruction of the Scope for some time interval, perhaps a few minutes. We must be careful to accelerate the Scope destruction when the stats store gets destructed (server exit, or unit-test completion).