Lazy evaluation of compression decision in compressor_filter for http response w/o content-length
#21,807 opened on 2022年6月21日
Repository metrics
- Stars
- (27,997 stars)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
If you are reporting any crash or any potential security issue, do not open an issue in this repo. Please report the issue via emailing envoy-security@googlegroups.com where the issue will be triaged appropriately.
Title: One line description Buffer response header in compressor_filter and perform compression decision when receiving first data frame (encode_data)
Description:
Describe the issue.
Snap leverages on compressor_filter to perform response compression for gRPC responses. gRPC server doesnt add content-length to response header that the compressor filter will compress small response payload as well , which causes some overhead in egress bandwidth.
What Snap does(already running in prod env) is to perform a lazy evaluation when receiving first data frame instead of buffering all data frames.
Snap want to seek some feedback from envoy community that
- this operation is feasible (Snap can create a draft PR to review later)
- upstream the change to envoy
[optional Relevant Links:]
Any extra documentation required to understand the issue.