envoyproxy/envoy

Clean up PANIC macros

Open

#19,229 opened on 2021年12月9日

GitHub で見る
 (12 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
beginnerenhancementhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

https://github.com/envoyproxy/envoy/pull/19204 replaced NOT_REACHED_GCOVR_EXCL_LINE macros with more clear PANIC_DUE_TO_CORRUPT_ENUM macros.

While more clear, the panics are still suboptimal becasue doing break; instead of return; results in production crashes. These should be cleaned up and replaced with sensible defaults on a case by case basis.

コントリビューターガイド