envoyproxy/envoy

network: address interface should pair port:proto

Open

#17,429 opened on 2021年7月20日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/listenerhelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

As per the discussion here: https://github.com/envoyproxy/envoy/pull/17414

In a perfect world our Address interface should include proto with port, as the operating system treats TCP:1234 differently from UDP:1234. Unfortunately, this will have very large implications on the overall code structure. There are a few things we might consider here:

  1. Remove port from the primary Address interface, as certain use cases do not actually care about port and proto. For example DNS, IP tagging, etc.
  2. Introduce a AddressAndPort interface which includes an address as well as a port/proto pair. Then, any port must have an associated proto with it as well.

Either way this needs some thinking and prototyping.

コントリビューターガイド