envoyproxy/envoy
Why envoy behaves differently when envoy adds an error tag to trace according to HTTP and GRPC status?
オープン
#15,883 opened on 2021/04/08
area/tracingenhancementhelp wanted
Repository metrics
- Stars
- (27,997 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
Description: Envoy adds an error tag to trace when HTTP status is 5xx (NOT when HTTP status is 4xx). On the other hand, envoy adds an error tag to trace when GRPC status is not "OK".
I think envoy should not adds an error tag to trace when GRPC status is such as "NOT_FOUND" or "PERMISSION_DENIED" because they are equivalent to HTTP status 4xx.
Is there any intention for this difference?
Relevant Links: https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/observability/tracing#what-data-each-trace-contains