envoyproxy/envoy

Prevent addition of redundant protobuf imports

Open

#15,589 opened on 2021年3月20日

GitHub で見る
 (2 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/buildhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

description

we have a lot of redundant import warnings when generating protos

i have raised a pr to fix this upstream in cncf/xds (https://github.com/cncf/xds/pull/3)

i have previously removed them from the envoy codebase (#15329 ) and have just opened another PR to remove more recently added ones (#15588 )

it would be great if we prevented these from being added

the obvious way would be to turn warnings into errors (see https://github.com/protocolbuffers/protobuf/issues/3980)

the problem with this is that there are a lot of warnings about missing dir paths which i think is harder to fix (https://github.com/bazelbuild/bazel/issues/7157)

コントリビューターガイド