envoyproxy/envoy

add listener message validation based on semantic

Open

#15,372 opened on 2021年3月8日

GitHub で見る
 (8 comments) (0 reactions) (1 assignee)C++ (5,373 forks)batch import
area/configurationarea/listenerhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

We have tcp listener, udp listener, api listener in the same Listener message , and I am adding another internal listener.

These listeners have their own feature set. e.g. connection_balance_config should not be used by udp listener, filter_chains should only be used by tcp listener (and quic ?), not all sock options are for udp, vice versa.

We don't have adequate validation for the above implicit rules for now.

It's probably good to warn the user upon receiving listener config, starting from "some fields are contradicting or ignored" and eventually reject inconsistent config.

WDYT?

コントリビューターガイド