envoyproxy/envoy

Better document and/or improve tracing config precedence

Open

#15,050 opened on 2021年2月14日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/docsarea/tracinghelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

With the introduction of per-route tracing configuration, the precedence is:

I think the documentation could be structured better.

  1. The Tracing overview section links to the runtime setting, even though it's the coarsest configuration mechanism and doesn't allow for per-route configuration.
  2. The 3 configs documentations (linked above) would do better to link to each other, and the overview documentation would do better to link to all of them.

P.S. re (1) I'm not sure it's even intentional. Perhaps the desired outcome here is that runtime settings, being less specific, should not take precedence over per-route settings?

コントリビューターガイド