envoyproxy/envoy

[xds] ADS reject duplicate resources in grpc_mux

Open

#14,847 opened on 2021年1月28日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/xdsbughelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

Title: in grpc_mux_impl, let's reject a resonse when we see duplicate resources.

Description: see https://github.com/envoyproxy/envoy/blob/main/source/common/config/grpc_mux_impl.cc#L224 We want to not "dedup" but reject the response here when the emplace fails

new_grpc_mux_impl seems doesnt have same issue as it push dup resources to each xds impl, where the dup resources gets rejected.

Repro steps:

send a discoveryResponse with multiple resources with the same name. Envoy accepts it silently.

コントリビューターガイド