envoyproxy/envoy
GitHub で見るUnify header validation across all codecs (H1, H2 and H3)
Open
#10,646 opened on 2020年4月3日
area/httparea/quicarea/securityhelp wantedtech debt
Repository metrics
- Stars
- (27,997 stars)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
Presently H1 and H2 codecs use header validation which is a mix of the codec specific and some checks from nghttp2 library on top of it. This leads to inconsistencies in header validation across codecs and makes header validation hard to audit.
For more information see design specifications.
This change will include:
- Adding header validation according to the HTTP spec.
- Converting codecs to use unified header validation facility. This will only be applied for Balsa and oghttp2 codecs.
Deployment plan:
- Add opt-in for universal header validation for Balsa and oghttp2 in compatibility mode (fully compatible with the http-parser and nghttp2)
- After bake-in interval (i.e. one full release cycle) change the feature to opt-out
- Turn-off compatibility features to bring HTTP validation to RFC compliance one by one.