envoyproxy/envoy

windows: Add build verification step to ensure path lengths

Open

#10,581 opened on 2020年3月30日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/buildhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (平均マージ 8d) (30d で 378 merged PRs)

説明

The Windows path length limit is 260 characters and can potentially be exceeded as seen in https://github.com/envoyproxy/envoy/pull/10560. The compiler error emitted when the max path length is exceeded does not point to the actual problem by outputting No such file or directory. It is unclear if this is the only behavior.

Ideally, there would be an explicit check for these path lengths during the Windows build and failure output that clearly indicates the problem.

コントリビューターガイド