envoyproxy/envoy
GitHub で見るdns: use handles to prevent use-after-free problems between dns queries and callback targets
Open
#10,079 opened on 2020年2月17日
area/dnsenhancementhelp wanted
Repository metrics
- Stars
- (27,997 stars)
- PR merge metrics
- (平均マージ 8d) (30d で 378 merged PRs)
説明
Description: ActiveDnsQueries have independent lifetimes from their callback targets (strict/logical dns cluster, dns cache). Right now there is an implicit contract where the callback target sets their query pointer to null once the query is resolved, and the query only fires callbacks if it has not been cancelled. However, this implicit contract can create problems when it's not adhered to (e.g #10006).
An enhancement would be to use handles with RAII constraints similar to how the init manager does with watchers and targets.