emscripten-core/emscripten

WebIDL binder: Use WeakRefs in cache

Open

#9,854 opened on 2019年11月18日

GitHub で見る
 (7 comments) (2 reactions) (0 assignees)C++ (3,519 forks)batch import
good first bughelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (平均マージ 19d 10h) (30d で 147 merged PRs)

説明

The cache maps C pointers (integers) to JS object wrappers. It currently keeps objects alive forever. This is normally ok as the objects should be manually destroy()ed, however, we do allow wrapping a class as a parent class, and then it ends up in multiple caches, see https://github.com/kripken/ammo.js/issues/284

Using WeakRefs where available could avoid this. However, until they are present everywhere, perhaps we could analyze the inheritance graph and clean up parent caches too, but that may be tricky especially with multiple/virtual/etc. inheritance.

コントリビューターガイド