Unreachable code "reached" when trying to render a non-string with the component helper · emberjs/ember.js#18072

(1 comment) (0 reactions) (0 assignees)JavaScript (22,437 stars) (4,216 forks)batch import

BugGood for New ContributorsHas ReproductionHelp Wanted

説明

Ember Twiddle doesn't let me go above 3.4, but I'm reproducing this on a 3.10 app (during a migration from 2.18).

This is less of a bug and more of something that could have a helpful debug assertion. Maybe something like:

You passed [Object object] to the {{component}} helper, but the component helper only accepts strings or other components.

Along with maybe a log of what that object was.

(This might not be the right repo for this, since it seems to deal with glimmervm internals)

技術スタック: javascript
領域: frontend
Issue 種別: feature
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: mostly clear
前提条件: basic Ember.js knowledgeunderstanding of component helper
初心者向け度: 60
調査方針: The issue requests adding a debug assertion when a non string/non component is passed to the {{component}} helper. The relevant code likely resides in ember.js's glimmer packages, specifically the component helper implementation. Look for files in packages/ember glimmer that handle the component helper, such as lib/component.js or similar. The existing error handling for invalid arguments should be located, and a new assertion can be added following Ember's debugging patterns. Check if there are any existing tests for the component helper to ensure the new assertion is covered.