emberjs/ember.js

Router Service: Behaves differently in engine context regarding route path

Open

#17,014 opened on 2018年9月28日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)JavaScript (22,437 stars) (4,216 forks)batch import
BugHelp WantedRouting

説明

Hey there,

it seems like the router services behaves differently in an engine context compared to {{#link-to}} in views and transitionTo routes.

Example: I want to link to my engine's route called 'overview'. The engine is mounted as 'engine'.

This is the expected and documented behavior: Route: this.transitionTo('overview') Views: {{#link-to 'overview'}}Link{{/link-to}}

Whereas the service requires the mount point additionally: Service: this.routerService.transitionTo('engine.overview')

I think all three ways should require the same route path.

Versions:

  • ember-source: ~3.2.0
  • ember-engines: ~0.5.4

Hopefully, there's no other issue like that, but haven't found any while searching. Thanks!

コントリビューターガイド

技術スタック
javascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Ember.js basicsEmber Engines concept
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
Investigate the router service implementation in ember.js, likely in packages/@ember/routing/lib/router service.js. Compare the behavior of transitionTo in the service vs link to helper and transitionTo on the route. The issue indicates that in an engine context, the service requires the mount point prefix (e.g., 'engine.overview') while other methods do not. Look at how the router service resolves routes relative to the engine's mount point. Check if there is a normalization step missing or if the service should use the engine's root URL. Review any existing tests for router service in engine context under packages/@ember/routing/tests/.