emberjs/ember-test-helpers

Input events should be instantiated with `{ composed: true }`

オープン

#1,201 opened on 2022/03/03

 (2 件のコメント) (1 件のリアクション) (0 人の担当者)JavaScript (256 件のフォーク)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (188 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

The composed property determines whether an event that occurs in shadow DOM will bubble to the host element.

Link to MDN docs.

In HTML, all form control input events are composed 1 2.

Presently, we are not instantiating input events with { composed: true }. See for example fillIn and select. I have not looked if there are other places. It probably makes sense to make this change in fireEvent itself similar to how bubbles is true by default.

Footnotes

  1. Search for "Fire an event named input" on https://html.spec.whatwg.org/multipage/input.html and https://html.spec.whatwg.org/multipage/form-elements.html.

  2. Change events are not composed.

コントリビューターガイド