ember-fastboot/ember-cli-fastboot

Figure out why some tests need application-template-wrapper enabled to pass

Open

#838 opened on 2021年6月21日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (853 stars) (163 forks)batch import
Good for New Contributorsgood first issuetest

説明

As part of my work to upgrade ember-cli-fastboot using ember-cli-update I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in this commit and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

コントリビューターガイド

技術スタック
javascript
領域
testing
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Ember.jsFastBootTesting with QUnit
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
First, revert the commit mentioned (b7c3934) to see which tests fail. Then examine the test selectors that may rely on the application template wrapper div. Look for tests that use selectors like '#ember testing' or similar. Check if the failing tests can be fixed by updating selectors or by enabling the wrapper. Report findings in the issue.