elastic/kibana

[Snapshot Restore] Disable navigation via step name when the form is invalid

Open

#99,041 opened on 2021年5月3日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Snapshot and RestoreTeam:Kibana Managementbuggood first issuepapercut

説明

Relates to #95876 fixed by PR#95939.

When a step (index settings) is invalid, it's possible to navigate to the previous step (logistics) by clicking its name in the wizard top navigation bar. That way the wizard will be blocked on the 1st step with a disabled 'next' button.

https://user-images.githubusercontent.com/6585477/116881324-6ac41400-ac23-11eb-8721-6df3210ca2d3.mp4

To reproduce:

  1. start ES with a folder for snapshots by adding -E path.repo=/tmp/es-snaps to your ES start command
  2. create a snapshot repository and a policy
  3. run the policy
  4. navigate to snapshots list and try to restore a snapshot
  5. in the wizard navigate to 'index settings' step
  6. enable "Modify index settings" to introduce a form error
  7. navigate to the previous step by clicking 'Logistics' in the top navigation bar

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactKibana plugin developmentForm validation
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue involves the snapshot restore wizard in Kibana. Look at the wizard component responsible for step navigation, likely in `x pack/plugins/snapshot restore/` directory. The previous fix in PR#95939 addressed a similar issue but did not prevent navigation via clicking step names. Investigate how the step names are rendered and ensure they are disabled when the form is invalid. Check the form validation state and propagate it to the navigation bar.