elastic/kibana

[Ingest Manager] Update EuiComboBox to render single select options as plain text

Open

#75,005 opened on 2020年8月13日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Team:Fleetgood first issue

説明

There are places in Ingest Manager where we use EuiComboBox but only allow a single option to be selected. In these cases, we've been using the "badge" style like this:

image

EUI allows you to render the option as plain text, like this: image

We should update all of the places where we have this "single select" behavior to use plain text. For example, the "namespace" field shown under advanced settings when creating an Agent config / policy has this. I think this also appears in the Add / edit integration workflow. We should be able to find all the places we do this by searching the Ingest Manager codebase for the singleSelection prop.

See the "Single selection" section in the EUI docs for more information.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
ReactEUIKibana codebase familiarity
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Find all uses of the `singleSelection` prop in the Ingest Manager codebase. Search for `<EuiComboBox singleSelection` in the files under `x pack/plugins/ingest manager/`. For each instance where only one option is selectable, change the `renderOption` prop to use plain text instead of the default badge style. Refer to the EUI documentation on single selection combo boxes for the correct prop to pass. Test that the change works visually and does not break any functionality.