elastic/kibana

[BUG] Node attributes aren't escaped in API requests

Open

#57,203 opened on 2020年2月10日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:ILMTeam:Kibana Managementbuggood first issuetriage_needed

説明

Elasticsearch version (bin/elasticsearch --version): 7.5.2

Plugins installed: [] None

JVM version (java -version):

/usr/share/elasticsearch/jdk/bin/java --version
openjdk 13.0.1 2019-10-15
OpenJDK Runtime Environment AdoptOpenJDK (build 13.0.1+9)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 13.0.1+9, mixed mode, sharing)

OS version (uname -a if on a Unix-like system): Linux elasticsearch1 4.15.0-76-generic elastic/elasticsearch#86-Ubuntu SMP Fri Jan 17 17:24:28 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Description of the problem including expected versus actual behavior: In ILM policy, after setting node attribution for shard awareness, clicking View a list of nodes attached to this configuration results in an error, if the node attribute contains an / (forward slash) I expect to see which nodes have said key :)

Steps to reproduce:

  1. Create a node.attr.node: "hot/warm"
  2. Create an ILM policy, enabling Warm phase
  3. In the warm phase, set Select a node attribute to control shard allocation to node: hot/warm
  4. Click on View a list of nodes attached to this configuration => Error is shown
  5. Opening the request in a new window (url taken from the request): https://kibana:5601/api/index_lifecycle_management/nodes/node:hot/warm/details fails, but encoding the / in the node.attr key, resolves the issue: https://kibana:5601/api/index_lifecycle_management/nodes/node:hot%2Fwarm/details

Provide logs (if relevant):

コントリビューターガイド

技術スタック
typescriptreactnodejsrest api
領域
frontendapi
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScriptHTTP requests
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Investigate the frontend code that constructs the API URL for fetching node details in the ILM policy UI. Look for the component that triggers the request when clicking 'View a list of nodes attached to this configuration'. The attribute value should be URL encoded before being appended to the path. Use encodeURIComponent or similar. The relevant files are likely in the 'x pack/plugins/index lifecycle management' directory. Check the URL building logic and ensure special characters like '/' are encoded.
[BUG] Node attributes aren't escaped in API requests · elastic/kibana#57203 | Good First Issue