elastic/kibana

[saved objects] Improve type safety in the saved objects repository

オープン

#239,468 opened on 2025/10/17

 (4 件のコメント) (0 件のリアクション) (1 人の担当者)TypeScript (8,021 件のフォーク)batch import
Feature:Saved ObjectsTeam:Coregood first issue💝community

Repository metrics

Stars
 (19,065 個のスター)
PR merge metrics
 (PR metrics pending)

説明

The is an existing pattern of using // @ts-expect-error MultiGetHit._source is optional comments in the saved object repository code that weakens the type safety. We should use a type guard instead

/**
 * Type guard to check if an item is a GetGetResult.
 */
export function isGetGetResult<TDocument = unknown>(
  item: MgetResponseItem<TDocument>
): item is GetGetResult<TDocument> {
  return (item as MgetMultiGetError).error === undefined;
}

Originally posted by @rudolf in https://github.com/elastic/kibana/pull/224411#discussion_r2348988329

コントリビューターガイド