elastic/elasticsearch

Improve logging for circuit breakers

Open

#62,452 opened on 2020年9月16日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)Java (25,882 forks)batch import
:Core/Infra/Circuit Breakers:Core/Infra/Logging>enhancementTeam:Core/Infrahelp wanted

Repository metrics

Stars
 (76,700 stars)
PR merge metrics
 (平均マージ 2d) (30d で 1,000 merged PRs)

説明

Logs should be more detailed about the circuit breaker when tripped.

Existing log example:

"Caused by: org.elasticsearch.common.breaker.CircuitBreakingException: [parent] Data too large, data for [cluster:monitor/nodes/info[n]] would be [33958682092/31.6gb], which is larger than the limit of [32386737766/30.1gb], real usage: [33958603128/31.6gb], new bytes reserved: [78964/77.1kb], usages [request=0/0b, fielddata=0/0b, in_flight_requests=78964/77.1kb, accounting=0/0b]",

Log should include name of circuit breaker that was broken, [parent] is not descriptive enough. Should include information about the request that tripped the circuit breaker. When you have hundreds of requests per second, it is nearly impossible to tell which request or request type tripped the breaker.

コントリビューターガイド