elastic/elasticsearch

Log all index settings updates at INFO level

オープン

#52,871 opened on 2020/02/27

 (7 件のコメント) (1 件のリアクション) (0 人の担当者)Java (25,882 件のフォーク)batch import
:Core/Infra/Settings>enhancementTeam:Core/Infrahelp wantedtriaged

Repository metrics

Stars
 (76,700 個のスター)
PR merge metrics
 (平均マージ 2d) (30d で 1,000 merged PRs)

説明

Most updates to index settings are handled by a settings update consumer registered via IndexScopedSettings#addSettingsUpdateConsumer. In contrast, the settings defined in IndexMetaData (index.blocks.*, index.priority, etc.) are consumed directly from the Settings object instead. Changes to index settings that are consumed via a settings update consumer result in an INFO-level log message (see e.g. #49969). Changes to directly-consumed settings do not automatically result in any log messages, and we explicitly handle some special cases like index.number_of_replicas elsewhere.

I think this is confusing since from a user's perspective there's no way to distinguish these two classes of index settings. A user seeing that some settings updates are logged may wrongly infer that the lack of logging of other settings updates means that those other settings were not updated.

Should we make this consistent? Consistency is good, but noisier logs are bad.

コントリビューターガイド