elastic/elasticsearch

Consistency between `_search` and `_msearch`

Open

#4,227 opened on 2013年11月21日

GitHub で見る
 (38 comments) (1 reaction) (1 assignee)Java (76,700 stars) (25,882 forks)batch import
:Search Foundations/Search>bugTeam:Search Foundationsgood first issuehelp wantedpriority:normal

説明

The _msearch API doesn't accept the same header parameters than _search's query parameters. For instance version is both valid in the search body and query parameters for _search, but is ignored in the query parameters and header in _msearch.

MultiSearchRequest.add() should rely on RestSearchAction.parseSearchSource() or even RestSearchAction.parseSearchRequest() to parse the subrequests, for maximum compatibility.

IMHO, a clean bulk API should use the header parameters as query parameters on the target endpoint, which would imply that they keep in sync no matter the code changes in the target endpoints.

コントリビューターガイド

技術スタック
javarest api
領域
apibackend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
over 1 week
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaElasticsearch internalsREST API module
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
15
調査方針
The issue is about ensuring that the msearch API accepts the same header parameters as search's query parameters. The proposed solution is to modify MultiSearchRequest.add() to use RestSearchAction.parseSearchSource() or parseSearchRequest() for parsing subrequests. Start by examining the current implementation of MultiSearchRequest.add() in the Elasticsearch codebase, and study how RestSearchAction handles query parameters like 'version'. Look at the linked comments for discussions on desired behavior. Then implement the changes to delegate parsing accordingly, ensuring backward compatibility.
Consistency between `_search` and `_msearch` · elastic/elasticsearch#4227 | Good First Issue