eduaguilera/whep

footprint_uncertainty: propagate_fp_uncertainty accepts malformed probs unvalidated

オープン

#215 opened on 2026/07/22

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)R (3 件のフォーク)auto 404
area:footprintbuggood first issuehelp wantedmechanicalno-data-neededpriority:low

Repository metrics

Stars
 (1 個のスター)
PR merge metrics
 (PR metrics pending)

説明

What

propagate_fp_uncertainty() (R/footprint_uncertainty.R:154-169, 185-195) merges options$probs with no length/range check. probs = c(0.05, 0.95) errors only after all n draws are computed (probs[3] → NA in quantile), and unordered probs silently produce q_low > q_high.

Suggested fix / check

Validate probs (length, range [0,1], ordering) at entry before drawing.


From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.

コントリビューターガイド