eduaguilera/whep
footprint_sankey: a genuine category literally named "Other" is merged into the grouped bucket
オープン
#214 opened on 2026/07/22
area:footprintbuggood first issuehelp wantedmechanicalno-data-neededpriority:low
Repository metrics
- Stars
- (1 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
What
.sankey_group_small_nodes() (R/footprint_sankey.R:442-455, mirrored in JS at :673) excludes any node equal to other_label from the keep-set, so a real item/area label "Other" (which occurs in FAO-style nomenclatures, e.g. "Meat, Other") is silently pooled with truncated small nodes, misattributing its flow.
Suggested fix / check
Key the small-node bucket on a sentinel that cannot collide with a real label, or track group membership separately from the display label.
From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.