eclipse-theia/theia

Terminal commands missing in certain instances.

オープン

#8,100 opened on 2020/06/26

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (2,478 件のフォーク)batch import
bugcommandshelp wantedquick-open

Repository metrics

Stars
 (18,676 個のスター)
PR merge metrics
 (平均マージ 15d 4h) (30d で 75 merged PRs)

説明

Bug Description:

The isEnabled handler for many terminal commands may be incorrect. If you give the terminal focus and use CTRL+SHIFT+P you will see commands like clear terminal, however, if you use CTRL+P then type >, you will not see this command. My thinking is that the isEnabled handler is looking at the focused widget, which in the case of CTRL+P, >, is probably the quick open.

Steps to Reproduce:

  1. Use CTRL+P, > with terminal focused, look for Terminal: Clear
  2. Use CTRL+SHIFT+P, with terminal focused, look for Terminal: Clear

Additional Information

  • Operating System: Linux lnx 5.3.0-59-generic #53~18.04.1-Ubuntu SMP Thu Jun 4 14:58:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
  • Theia Version: 1.2

コントリビューターガイド