eclipse-theia/theia

Preference change does not fire an onPreferencedChanged event

Open

#7,685 opened on 2020年4月28日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedpreferences

説明

Bug Description:

While working on the new preferences-ui we came across a bug related to the preference-service that has been causing some strange and unpredictable behavior on the Electron version (and also appears on master with the original preferences UI). When setting a preference value for some items, most noticeably Application Confirm Exit in User scope, the preference service does not properly register an onPreferenceChanged event, and thus does not update the value in the UI. This has sometimes occurred for other preference items in folder scopes as well, but is consistently an issue for Application Confirm Exit Please see the attached screen recording with console output:

Steps to Reproduce:

  1. Set up a log for the preferenceService.onPreferenceChanged event (in e.g. packages/preferences/src/browser/preferences-decorator.ts around line 36)
  2. Build for Electron
  3. Run in Electron
  4. Open Preferences in User scope
  5. Modify preferences using tree view and save the JSON
  6. Every modify + save cycle should fire an onPreferenceChanged event.
  7. Modify 'Application: Confirm Exit' and save
  8. Observe that no event fires

screenrecord

Additional Information

  • Operating System: Linux (RHEL7 & Ubuntu tested)
  • Theia Version: Electron 1.0.0

コントリビューターガイド

技術スタック
typescriptelectronnodejs
領域
full stackdesktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScriptTheia frameworkEvent driven programming
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Start by examining the preference service event emission in packages/preferences/src/browser/preferences decorator.ts (around line 36). Investigate why the 'Application: Confirm Exit' preference in User scope does not trigger onPreferenceChanged. Check the implementation of preference service to see if the event is properly registered and if the change is detected. Review the issue comments for any additional context or hints.
Preference change does not fire an onPreferencedChanged event · eclipse-theia/theia#7685 | Good First Issue