eclipse-theia/theia

textEditor.commands.showReferences command fails after assigning keybinding

Open

#5,559 opened on 2019年6月21日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (18,676 stars) (2,478 forks)batch import
bughelp wantedkeybindingsmonaco

説明

Description

When you run the textEditor.commands.showReferences command after assigning it a keybinding it fails with:

TypeError: Cannot read property 'map' of undefined
    at Object.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command.ts:138:31)
    at MonacoCommandRegistry.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command-registry.ts:72:57)
    at Object.execute (/home/joshpinkney/Documents/Work/theia/packages/monaco/src/browser/monaco-command-registry.ts:61:47)
    at KeybindingRegistry.tryKeybindingExecution (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/keybinding.ts:570:44)
    at KeybindingRegistry.run (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/keybinding.ts:619:18)
    at HTMLDocument.<anonymous> (/home/joshpinkney/Documents/Work/theia/packages/core/src/browser/frontend-application.ts:164:72)

Reproduction Steps

Opening the keybinding shortcuts widget, assign keybinding, open a typescript file and put it over something you would expect to work with show references.

Expected: showReferences is brought up

Result: The error listed above

コントリビューターガイド

技術スタック
typescript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
familiarity with Theia codebasebasic understanding of monaco editor
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the error at packages/monaco/src/browser/monaco command.ts line 138 where 'Cannot read property 'map' of undefined' occurs. The issue is that when the command is triggered via a keybinding, the argument expected by showReferences is undefined. Compare how the command is called normally vs via keybinding and ensure the necessary argument is passed. Check the KeybindingRegistry execution path in packages/core/src/browser/keybinding.ts.
textEditor.commands.showReferences command fails after assigning keybinding · eclipse-theia/theia#5559 | Good First Issue