dtolnay/cargo-expand

Show progress bar

オープン

#62 opened on 2019/04/20

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Rust (73 件のフォーク)github user discovery
help wanted

Repository metrics

Stars
 (3,090 個のスター)
PR merge metrics
 (平均マージ 4m) (30d で 1 merged PR)

説明

Currently the Cargo subprocess spawned by cargo-expand does not display Cargo's usual progress bar. I believe this is because we pipe the child's stderr to perform filtering here:

https://github.com/dtolnay/cargo-expand/blob/3ae4ca126a4bd557ef7f7954911d65db56525b37/src/main.rs#L358

and that means Cargo does not get a winsize from this ioctl:

https://github.com/rust-lang/cargo/blob/6be12653dcefb46ee7b605f063ee75b5e6cba513/src/cargo/core/shell.rs#L377

I tried a naive fix in #61 but it didn't work, the second ioctl fails with:

Inappropriate ioctl for device (os error 25)

Will need to figure out what's the correct way to provide a winsize to the child process.

コントリビューターガイド