downshift-js/downshift

[useSelect] Selecting item with spacebar in firefox reopens the menu

Open

#1,197 opened on 2020年11月18日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)JavaScript (980 forks)batch import
bughelp wantedneeds investigation

Repository metrics

Stars
 (11,761 stars)
PR merge metrics
 (平均マージ 6d 9h) (30d で 5 merged PRs)

説明

  • downshift version: 6.0.6
  • firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

コントリビューターガイド