dotnet/winforms

DataGridView not dispose old elements

オープン

#6,859 opened on 2022/03/17

 (11 件のコメント) (0 件のリアクション) (0 人の担当者)C# (922 件のフォーク)batch import
area-controls-DataGridViewhelp wantedtenet-performance

Repository metrics

Stars
 (4,100 個のスター)
PR merge metrics
 (PR metrics pending)

説明

  • .NET Core Version: all up to 7.0 p2

  • Have you experienced this same bug with .NET Framework?: Yes

Problem description: As I mentioned in https://github.com/dotnet/winforms/issues/6858 DataGridView not dispose old data on DataSource change. This is lead to 2 problems:

  1. All this stuff are going to finalization query because we have unnecessary finalizer here #6858.
  2. If we have a ContextMenuStrip bound to Cell/Column/Row we will have a memory leak. DataGridView with 3 columns and ContextMenuStrip bound to 1000 rows, result of DS refresh: image

Expected behavior: Old data must be property disposed. Probably in DataGridView.RefreshColumnsAndRows() (in DataGridView.Methods.cs)

Minimal repro: DataGridViewLeak.zip

コントリビューターガイド