dotnet/tye

Make it clearer that proxy containers are not where project services are running

Open

#380 opened on 2020年4月17日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C# (5,310 stars) (532 forks)batch import
buggood first issuehelp wanted

説明

Looking at a log for the voting app:

[13:42:21 INF] Running image redis for redis_06610a82-7
[13:42:21 INF] Running image postgres for postgres_190bd61a-2
[13:42:21 INF] Running image mcr.microsoft.com/dotnet/core/sdk:3.1 for vote-proxy_105de2c0-e
[13:42:21 INF] Running image mcr.microsoft.com/dotnet/core/sdk:3.1 for worker-proxy_70879c25-7

This confused me for a second because I thought my projects were being run as containers, even though it's just the proxy. I'd recommend we change the log message to something like:

[13:42:21 INF] Running proxy image mcr.microsoft.com/dotnet/core/sdk:3.1 for worker-proxy_70879c25-7 to communicate with other docker images.

Or something to that effect.

コントリビューターガイド

技術スタック
csharpdocker
領域
developer experiencebackend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
1
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
なし
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
90
調査方針
Search the codebase for the log messages shown in the issue, specifically the lines that print 'Running image' for proxy containers. The likely location is in the local orchestrator code (e.g., under src/). Modify the log message to clearly indicate that it is a proxy container, e.g., 'Running proxy image ...' or append 'to communicate with other docker images' as suggested. Ensure all similar proxy log messages are updated.
Make it clearer that proxy containers are not where project services are running · dotnet/tye#380 | Good First Issue