dotnet/tye

Make it clearer that proxy containers are not where project services are running

Open

#380 opened on 2020年4月17日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C# (532 forks)batch import
buggood first issuehelp wanted

Repository metrics

Stars
 (5,310 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Looking at a log for the voting app:

[13:42:21 INF] Running image redis for redis_06610a82-7
[13:42:21 INF] Running image postgres for postgres_190bd61a-2
[13:42:21 INF] Running image mcr.microsoft.com/dotnet/core/sdk:3.1 for vote-proxy_105de2c0-e
[13:42:21 INF] Running image mcr.microsoft.com/dotnet/core/sdk:3.1 for worker-proxy_70879c25-7

This confused me for a second because I thought my projects were being run as containers, even though it's just the proxy. I'd recommend we change the log message to something like:

[13:42:21 INF] Running proxy image mcr.microsoft.com/dotnet/core/sdk:3.1 for worker-proxy_70879c25-7 to communicate with other docker images.

Or something to that effect.

コントリビューターガイド