dotnet/runtime

Improve APIs for Intel string handling intrinsics

オープン

#957 opened on 2018/06/13

 (14 件のコメント) (2 件のリアクション) (0 人の担当者)C# (5,445 件のフォーク)batch import
arch-x64area-System.Runtime.Intrinsicshelp wanted

Repository metrics

Stars
 (17,886 個のスター)
PR merge metrics
 (平均マージ 12d 11h) (30d で 661 merged PRs)

説明

See https://github.com/dotnet/coreclr/pull/17637 for some discussion and context. The fundamental issues revolve around how much of the behavior should be controlled by enums passed into the intrinsic method, versus separating the different behaviors into differently-named intrinsics.

The current API includes both StringComparisonMode (https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs#L864) and ResultsFlag (https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs#L875).

Some of the open questions are:

  • Should the ResultsFlag, which determines the comparison results for which a true result is returned, become part of the method name?
  • How should these be named? According to the instruction documentation (e.g. CFlag, as in the current API), or something more descriptive like CompareNonZeroMask?
  • Should these be combined into a single enum or remain separate?

コントリビューターガイド