dotnet/runtime

[mono] MonoImage->references reads should be atomic

Open

#32,889 opened on 2020年2月26日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-VM-meta-monogood first issueruntime-mono

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (平均マージ 12d 11h) (30d で 661 merged PRs)

説明

As of https://github.com/dotnet/runtime/pull/32622 we will take the image lock when writing to references, but reads throughout the code are currently done directly and without locking. This should be changed to use accessor functions that read in the pointer atomically.

This isn't time-critical as I don't believe we've seen many (any?) crashes related to this, but is worth noting and changing for completeness' sake.

コントリビューターガイド