dotnet/runtime

Improve custom attribute decoding tests

オープン

#16,552 opened on 2016/03/01

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)C# (5,445 件のフォーク)batch import
area-System.Reflection.Metadatahelp wantedtest-enhancement

Repository metrics

Stars
 (17,886 個のスター)
PR merge metrics
 (平均マージ 12d 11h) (30d で 661 merged PRs)

説明

Currently, due to lack of time, some tests just check that we don't throw. A better approach would probably be to generically compare reflection CustomAttributeData to S.R.M CustomAttributeValue for every test attribute applied.

Also, there needs to be test cases for malformed custom attributes. Test coverage is at ~70% now with only positive cases.

コントリビューターガイド