dotnet/runtime

Remove unsafe code from number parsing

Open

#10,397 opened on 2018年5月29日

GitHub で見る
 (11 comments) (3 reactions) (0 assignees)C# (5,445 forks)batch import
Cost:Marea-System.Numericshelp wantedreduce-unsafe

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (平均マージ 12d 11h) (30d で 661 merged PRs)

説明

There is heavy use of unsafe code in number.parsing.cs and calling code (eg at https://github.com/dotnet/runtime/blob/110282c71b3f7e1f91ea339953f4a0eba362a62c/src/libraries/System.Private.CoreLib/src/System/Number.Parsing.cs#L255). This could be rewritten with ReadOnlySpan<char> to eliminate the char * resulting in safer code that is also easier to read.

Relates to https://github.com/dotnet/coreclr/pull/17808

コントリビューターガイド