dotnet/roslyn

Fixing CS7036 (generate constructor based on base class) should give an option to use Primary Constructor

Open

#74,602 opened on 2024年7月30日

GitHub で見る
 (4 comments) (1 reaction) (0 assignees)C# (4,257 forks)batch import
Area-IDEhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (平均マージ 6d 17h) (30d で 256 merged PRs)

説明

Discussed in https://github.com/dotnet/roslyn/discussions/74598

Originally posted by datvm July 30, 2024 I am not sure if this is a duplicate because I think this is a very popular scenario. Assume we have this code:

class BaseClass(CancellationToken ct)
{

}

class DerivedClass : BaseClass
{
}

VS would suggest to "Generate constructor 'DerivedClass(ct)'":

image

After that, VS continues to suggest to use Primary Constructor instead which gives this code:

class DerivedClass(CancellationToken ct) : BaseClass(ct)
{
}

I think the analyzer should merge the two steps into one?

コントリビューターガイド