dotnet/roslyn

VB.NET AnalyzeDataFlow incorrectly reports parameters as WrittenInside

Open

#68,286 opened on 2023年5月22日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (平均マージ 6d 17h) (30d で 256 merged PRs)

説明

Version Used: 4.6.0

Steps to Reproduce:

Use following source code to analyse

Public Sub Test(i As Integer)
    Dim s = i.ToString()
End Sub

with following visitor

public override SyntaxNode VisitMethodBlock(MethodBlockSyntax node)
{
    var first = node.Statements.First();
    var last = node.Statements.Last();
    var dataFlow = semanticModel.AnalyzeDataFlow(first, last);
    Debug.Assert(dataFlow.WrittenInside.Length == 1);

    return node;
}

Expected Behavior: dataFlow.WrittenInside should not contain Parameter i As System.Int32, only Local s As System.String

Actual Behavior: dataFlow.WrittenInside contains Parameter i As System.Int32.

Notes: Equivalent code in C# is analysed as expected, the parameter is not part of the dataFlow.WrittenInside.

I suspect this line: https://github.com/dotnet/roslyn/blob/687921ffae8ad91a5464473cb1759fd463c345f2/src/Compilers/VisualBasic/Portable/Analysis/FlowAnalysis/DataFlowPass.vb#L1537

コントリビューターガイド