dotnet/roslyn
Suggestion to use `obj is SomeConst` instead of safe cast or direct Equals(object) call
オープン
#45,232 opened on 2020/06/16
Area-IDEConcept-Continuous Improvementhelp wanted
Repository metrics
- Stars
- (20,414 個のスター)
- PR merge metrics
- (平均マージ 6d 17h) (30d で 256 merged PRs)
説明
obj as string == "x" and "x".Equals(obj) would be replaced with obj is "x".
This could apply to all constant types, so obj as bool? == SomeBoolConstant and SomeBoolConstant.Equals(obj) would be replaced with obj is SomeBoolConstant.
When CS0252 "Possible unintended reference comparison; to get a value comparison, cast the left hand side to type 'string'" is reported, this fix could offer to change obj == "x" to obj is "x".
Happy to implement.