dotnet/roslyn

VB compiler should not "optimize" Select statements during initial binding

Open

#374 opened on 2015年2月10日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugConcept-Design DebtLanguage-VBhelp wanted

説明

The VB compiler "optimizes" Select statements during initial binding, generating and storing a lowered form for the cases depending on the structure of the whole select statement.

Generally speaking such transformations belong in lowering. Since it operates at the level of the whole Select statement after all of the parts have been bound, it can be moved en masse to a later phase. I recommend the local lowering phase.

Any intermediate phases that depend on the lowering having taken place are likely buggy, since different lowered forms may be generated in different circumstances.

[ported from TFS DevDiv 941313]

コントリビューターガイド

技術スタック
csharp
領域
toolingperformance
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
compiler internalsRoslyn architectureVB.NET syntaxlowering phases
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
25
調査方針
Examine the VB compiler's initial binding phase to locate the premature optimization of Select statements. The issue recommends moving this transformation to the local lowering phase. Review the lowering pass structure in the Roslyn repository, likely in the 'Features/VisualBasic' or 'Compilers/VisualBasic' directories. Check linked TFS issue for more context.
VB compiler should not "optimize" Select statements during initial binding · dotnet/roslyn#374 | Good First Issue