dotnet/roslyn
Should protected abstract methods in SemanticModel be private protected instead?
オープン
#29,235 opened on 2018/08/12
Area-CompilersBugConcept-APIhelp wanted
Repository metrics
- Stars
- (20,414 個のスター)
- PR merge metrics
- (平均マージ 6d 17h) (30d で 256 merged PRs)
説明
I noticed that protected abstract methods on SemanticModel like GetDeclaredSymbolCore are documented in Roslyn's API reference. Since it's impossible to inherit from SemanticModel for users of the API, I think such methods should not be included in the API reference.
And I think the most reasonable way to do that is to change such methods to private protected. Do you agree?
It's possible there are more types like that in the codebase, but SemanticModel is the one where I noticed this.