dotnet/roslyn
Simplify logic for deconstruction variables in ExpressionVariableFinder
オープン
#15,064 opened on 2016/11/07
Area-CompilersConcept-Design DebtFeature - Tupleshelp wanted
Repository metrics
- Stars
- (20,414 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
Per discussion in PR https://github.com/dotnet/roslyn/pull/14871
- Maybe we don't need
MakeOutVariableandMakeDeconstructionVariable, instead one may suffice, by looking up the syntax tree. - Maybe we don't need
CollectVariablesFromDeconstructioninExpressionVariableFinder, instead we just need aVisitVariableDesignationwhich looks up the syntax tree to determine if it is an out or a deconstruction variable. - Then maybe we can re-use
ExpressionVariableFinderinstead ofForEachLoopBinder.CollectLocalsFromDeconstruction.