EE: Comment characters should be ignored in strings and XML literals · dotnet/roslyn#1453

2015-03-20T23:33:05.000Z

Ported from TFS WorkItem: 1120198 --- Repro Steps: 1. F5 the following class C { static object F(string s) { return new object(); } static void Main() { System.Diagnostics.Debugger.Break(); } } 2. Evaluate F("//") in the Watch window 3. Right-click on the expression and "Add Watch" Result: Invalid expression Same issue exists with VB with strings and XML literals: Imports System.Xml.Linq Class C Shared Function F(x As XElement) As Object Return New Object() End Function Shared Sub Main() System.Diagnostics.Debugger.Break() End Sub End Class --- Revisions: 1) Created By Chuck Stoner (2/5/2015 9:01:14 AM) ---

(0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import

Area-InteractiveBugInteractive-Debugginghelp wanted

説明

Ported from TFS WorkItem: 1120198

Created By Chuck Stoner (2/5/2015 9:01:14 AM)

コントリビューターガイド

技術スタック: csharp
領域: toolingdeveloper experience
Issue 種別: bug
難度: 4
推定時間: 1-2 days
活動状況: stale
明確さ: clear
前提条件: C# or VB knowledgefamiliarity with debugger expression evaluationunderstanding of Roslyn architecture
初心者向け度: 15
調査方針: The bug is in the expression evaluator (EE) for the Watch window, which incorrectly treats comment characters (e.g., '//') as comments even when inside string literals or XML literals. To fix, examine the EE's lexer/parser logic in the Roslyn debugger components, likely in the 'src/ExpressionEvaluator' directory. Determine where comment detection occurs and adjust to skip characters inside strings and XML literals. No prior discussion or linked PRs exist for this issue, so the fix can be implemented from scratch.